Return-Path: 
 <dev-return-4461-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8CCDD1793A
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Wed, 22 Jul 2015 21:28:30 +0000 (UTC)
Received: (qmail 84906 invoked by uid 500); 22 Jul 2015 21:28:17 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 84869 invoked by uid 500); 22 Jul 2015 21:28:17 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 84858 invoked by uid 99); 22 Jul 2015 21:28:17 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 21:28:17 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 69FC9E005E; Wed, 22 Jul 2015 21:28:17 +0000 (UTC)
From: Randgalt <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-92-curator@git.apache.org>
In-Reply-To: <git-pr-92-curator@git.apache.org>
Subject: [GitHub] curator pull request: TreeCache should inform listeners when
 its f...
Content-Type: text/plain
Message-Id: <20150722212817.69FC9E005E@git1-us-west.apache.org>
Date: Wed, 22 Jul 2015 21:28:17 +0000 (UTC)

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/92#discussion_r35266454
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCacheEvent.java ---
    @@ -69,6 +69,9 @@
              * While the connection is down, the TreeCache will continue to have its state from before it lost
              * the connection and after the connection is restored, the TreeCache will emit normal child events
              * for all of the adds, deletes and updates that happened during the time that it was disconnected.
    +         * </p><p>
    +         * After reconnection, the cache will resynchronize its internal state with the server, then fire a
    +         * {@link #INITIALIZED} event.
              * </p>
              */
             CONNECTION_RECONNECTED,
    --- End diff --
    
    Shouldn't isInitialized.set(false) occur for SUSPENDED (i.e. any connection loss)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---