Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: cammckenzie <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-79-curator@git.apache.org>
In-Reply-To: <git-pr-79-curator@git.apache.org>
Subject: [GitHub] curator pull request: [CURATOR-222] Container support
Content-Type: text/plain
Message-Id: <20150701005014.7F380E0098@git1-us-west.apache.org>
Date: Wed,  1 Jul 2015 00:50:14 +0000 (UTC)

Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/79#issuecomment-117380664
  
    @Randgalt, looks good to me. A couple of minor things for discussion.
    1.) Can the internal EnsurePath stuff in NamespaceImpl be replaced with the new container stuff?
    2.) When executing creatingContainerParentsIfNeeded(), I was wondering if some sort of warning log should be generated if the parents already exist and are not container nodes? I'm just thinking of the case where you try and create a hierachy of nodes and some of them already exist as persistent nodes. Maybe it's just up to the user to remove any existing parents if this is important?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---