curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-232) Consolidate test code
Date Sat, 18 Jul 2015 17:28:04 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632531#comment-14632531
] 

ASF GitHub Bot commented on CURATOR-232:
----------------------------------------

Github user Randgalt commented on the pull request:

    https://github.com/apache/curator/pull/89#issuecomment-122570334
  
    I'm concerned about the number of changes in this PR. I like the idea of putting some
common functionality in BaseClassForTests but I think it's too risky to touch all the tests.
I suggest that we add the things to BaseClassForTests but leave the tests as is an updated
them as needed over time.


> Consolidate test code
> ---------------------
>
>                 Key: CURATOR-232
>                 URL: https://issues.apache.org/jira/browse/CURATOR-232
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Mike Drob
>
> Writing additional tests for Curator can be fairly intimidating to new users, and it
looks like things just get copy and pasted a lot. We can consolidate a lot of test code, starting
with how we expose {{Timing}} and {{CuratorFramework}} objects. This is a probably going to
be a longer term effort with several JIRAs, so I'm not concerned with this one issue covering
absolutely everything, I just want to make new tests easier to write.
> One easy route is to make heavier use of annotations, like the {{@BeforeMethod}} and
{{@AfterMethod}} instead of {{try/finally}} when making sure resources are cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message