curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-232) Consolidate test code
Date Wed, 08 Jul 2015 23:19:04 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619562#comment-14619562
] 

ASF GitHub Bot commented on CURATOR-232:
----------------------------------------

GitHub user madrob opened a pull request:

    https://github.com/apache/curator/pull/89

    CURATOR-232 Consolidate Timing and Client

    Pull references to Timing and CuratorFramework client into BeforeMethod
    and AfterMethod invocations so that we can manage them more efficiently.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madrob/curator CURATOR-232

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit a1ff02690ebe24b4d4aa2c6d431c71e65ea14503
Author: Mike Drob <mdrob@cloudera.com>
Date:   2015-07-08T23:16:17Z

    CURATOR-232 Consolidate Timing and Client
    
    Pull references to Timing and CuratorFramework client into BeforeMethod
    and AfterMethod invocations so that we can manage them more efficiently.

----


> Consolidate test code
> ---------------------
>
>                 Key: CURATOR-232
>                 URL: https://issues.apache.org/jira/browse/CURATOR-232
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Mike Drob
>
> Writing additional tests for Curator can be fairly intimidating to new users, and it
looks like things just get copy and pasted a lot. We can consolidate a lot of test code, starting
with how we expose {{Timing}} and {{CuratorFramework}} objects. This is a probably going to
be a longer term effort with several JIRAs, so I'm not concerned with this one issue covering
absolutely everything, I just want to make new tests easier to write.
> One easy route is to make heavier use of annotations, like the {{@BeforeMethod}} and
{{@AfterMethod}} instead of {{try/finally}} when making sure resources are cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message