curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-232 Consolidate Timing and Client
Date Sat, 18 Jul 2015 17:27:12 GMT
Github user Randgalt commented on the pull request:

    https://github.com/apache/curator/pull/89#issuecomment-122570334
  
    I'm concerned about the number of changes in this PR. I like the idea of putting some
common functionality in BaseClassForTests but I think it's too risky to touch all the tests.
I suggest that we add the things to BaseClassForTests but leave the tests as is an updated
them as needed over time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message