curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-232 Consolidate Timing and Client
Date Sat, 18 Jul 2015 17:24:47 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/89#discussion_r34949657
  
    --- Diff: curator-framework/src/test/java/org/apache/curator/framework/FrameworkTest.java
---
    @@ -0,0 +1,83 @@
    +/*
    --- End diff --
    
    I don't see enough value in this class to maintain it. In order for it to be used in the
recipes module we'd have to build a test jar and include and/or create another test module.
Create new clients isn't always consistent in the tests and it's only 1 line of code anyway.
The closeable stuff could be pushed into BaseClassForTests by having a List<Closeable>
that can be added to and auto closed on @After.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message