curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-222] Container support
Date Wed, 01 Jul 2015 00:42:01 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/79#discussion_r33639772
  
    --- Diff: curator-recipes/src/test/java/org/apache/curator/framework/recipes/cache/TestPathChildrenCache.java
---
    @@ -100,16 +100,16 @@ public void childEvent(CuratorFramework client, PathChildrenCacheEvent
event) th
             }
         }
     
    -    @Test
    +    @Test(enabled = false)  // I didn't write this test and it's not working. I'm not
even sure what it tests. Check into it later -JZ
    --- End diff --
    
    What's the status of this? Looks like it was added as part of CURATOR-141, and I guess
it's trying to get the client to shutdown during the build process. It looks pretty flaky
though? Maybe we should just remove it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message