Return-Path: 
 <dev-return-4237-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2EFD518872
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Wed, 17 Jun 2015 04:09:10 +0000 (UTC)
Received: (qmail 3160 invoked by uid 500); 17 Jun 2015 04:09:10 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 3116 invoked by uid 500); 17 Jun 2015 04:09:10 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 3105 invoked by uid 99); 17 Jun 2015 04:09:09 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jun 2015 04:09:09 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 67199E3C4F; Wed, 17 Jun 2015 04:09:09 +0000 (UTC)
From: Randgalt <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-83-curator@git.apache.org>
In-Reply-To: <git-pr-83-curator@git.apache.org>
Subject: [GitHub] curator pull request: Add .executorService methods to
 ServiceCache...
Content-Type: text/plain
Message-Id: <20150617040909.67199E3C4F@git1-us-west.apache.org>
Date: Wed, 17 Jun 2015 04:09:09 +0000 (UTC)

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/83#discussion_r32594090
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java ---
    @@ -66,6 +68,18 @@
             cache.getListenable().addListener(this);
         }
     
    +    ServiceCacheImpl(ServiceDiscoveryImpl<T> discovery, String name, CloseableExecutorService executorService)
    --- End diff --
    
    Please have the other ctor call this one. You may need to introduce a third private ctor. i.e. only 1 ctor should have code. The others should forward to the 1 with code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---