curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <>
Subject [GitHub] curator pull request: CURATOR-219 Catch Exceptions, not Throwables
Date Sat, 20 Jun 2015 14:33:27 GMT
Github user Randgalt commented on a diff in the pull request:
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/
    @@ -812,31 +812,28 @@ private void performBackgroundOperation(OperationAndData<?>
    -        catch ( Throwable e )
    +        catch ( CuratorConnectionLossException e )
    --- End diff --
    Similar to above. If Throwable is not caught, the exception will be lost. By catching
Throwable, the exception will get logged.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message