curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdyas <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-223] Add executorService methods to...
Date Wed, 17 Jun 2015 15:45:05 GMT
Github user tdyas commented on a diff in the pull request:

    https://github.com/apache/curator/pull/83#discussion_r32641133
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
---
    @@ -66,6 +68,18 @@
             cache.getListenable().addListener(this);
         }
     
    +    ServiceCacheImpl(ServiceDiscoveryImpl<T> discovery, String name, CloseableExecutorService
executorService)
    --- End diff --
    
    Will do. I had to add a conversion from `ThreadFactory` to `CloseableExecutorService`
in a static method since Java doesn't permit ctor's to have code before the call to the common
ctor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message