curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdyas <...@git.apache.org>
Subject [GitHub] curator pull request: Add .executorService methods to ServiceCache...
Date Wed, 17 Jun 2015 03:36:57 GMT
Github user tdyas commented on a diff in the pull request:

    https://github.com/apache/curator/pull/83#discussion_r32593123
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/PathChildrenCache.java
---
    @@ -184,6 +184,28 @@ public PathChildrenCache(CuratorFramework client, String path, boolean
cacheData
         }
     
         /**
    +     * @param client        the client
    --- End diff --
    
    I was trying to avoid using the ctor's with the `dataIsCompressed` argument since `ServiceCacheImpl`
did not use those ctor's. I suppose it is fine to just invoke those ctor's and pass in `false`
for `dataIsCompressed`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message