curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Add .executorService methods to ServiceCache...
Date Wed, 17 Jun 2015 02:07:10 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/83#discussion_r32590333
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
---
    @@ -66,6 +68,30 @@
             cache.getListenable().addListener(this);
         }
     
    +    ServiceCacheImpl(ServiceDiscoveryImpl<T> discovery, String name, ExecutorService
executorService)
    --- End diff --
    
    I'd prefer to see 1 ctor. It can take a CloseableExecutorService. The builder can wrap
the executorService. I think there are other examples of this in the Curator code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message