Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Date: Fri, 8 May 2015 13:13:04 -0500
From: Jordan Zimmerman <jordan@jordanzimmerman.com>
To: dev@curator.apache.org, Sean Busbey <busbey@cloudera.com>
Cc: Mike Drob <madrob@cloudera.com>
Message-ID: <etPan.554cfcb0.2ae8944a.95b@Jordans-MacBook-Pro-2.local>
In-Reply-To: 
 <CAGHyZ6LqTh99nc0r+Vjm3NcuNrWvyQSP2aXXkuBq78q88Kc7=w@mail.gmail.com>
References: 
 <CABRiMSH6dOWcdC6CdGUq6LTYQ4C_cSTskF+SOZ=t4XZzqZBFLw@mail.gmail.com>
 <CA++geaDzPrgmCZrADJOO8JPTAduJVCfWL20QbbLG6BxkOskA-g@mail.gmail.com>
 <CAFAMeY+BGo66hez8ffRt_f0DnvCxvp1v_YaA6jgQ1=rmj_BTMQ@mail.gmail.com>
 <CANykdubXSyO1qJn5ucsvUz3WRtx1wVLk3XYCCGZfpU9inmv2OA@mail.gmail.com>
 <CAFAMeYKeyYwxO-+D209AvuqkUiTkZtcsJ0PycPuOc3VdzEFJOw@mail.gmail.com>
 <etPan.554cec4b.643c9869.15b@Jordans-MacBook-Pro-2.local>
 <CAFAMeYK4YqOv+9DabVpZsq1xF5APBw=MJuEncfkmpB2XqE8vOA@mail.gmail.com>
 <etPan.554cf052.6b8b4567.95b@Jordans-MacBook-Pro-2.local>
 <CAFAMeYJZ9jADgJHrLwtYPK4vsYJxqGfBQkvR+DFXTwfQW6oOiQ@mail.gmail.com>
 <etPan.554cf1fd.643c9869.95b@Jordans-MacBook-Pro-2.local>
 <etPan.554cf8a7.74b0dc51.95b@Jordans-MacBook-Pro-2.local>
 <CAGHyZ6LqTh99nc0r+Vjm3NcuNrWvyQSP2aXXkuBq78q88Kc7=w@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Curator version 2.8.0
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="554cfcb0_625558ec_95b"

--554cfcb0_625558ec_95b
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

What don=E2=80=99t you like about Clirr=3F I just tried it and it works w=
ell A=46AICT. The real benefit is the Maven integration. Also, I can have=
 it produce a report that can go on the website.

-Jordan


On May 8, 2015 at 1:11:20 PM, Sean Busbey (busbey=40cloudera.com) wrote:

I'm in process of adding the java api compliance checker (which I trust =20
more than Clirr) to the Hadoop Pre-commit Patch Tester. (which is a set u=
p =20
made to work with other projects via AS=46 jenkins). =20

Curator could rely on that instead of coming up with its own process. =20

On =46ri, May 8, 2015 at 10:55 AM, Jordan Zimmerman < =20
jordan=40jordanzimmerman.com> wrote: =20

> Even better. The Clirr plugin can do this for us as part of building. I=
=E2=80=99ll =20
> incorporate it. =20
> =20
> http://mojo.codehaus.org/clirr-maven-plugin/ =20
> =20
> =20
> =20
> On May 8, 2015 at 12:27:27 PM, Jordan Zimmerman ( =20
> jordan=40jordanzimmerman.com) wrote: =20
> =20
> I=E2=80=99ll take a stab at the script given your description below. Yo=
u can =20
> modify later. =20
> =20
> Thank you. =20
> =20
> =20
> =20
> On May 8, 2015 at 12:26:44 PM, Mike Drob (madrob=40cloudera.com) wrote:=
 =20
> =20
> Just to set expectations, I'm not sure I'll have time for this today. T=
his =20
> release might still have to have manual checking, unless you're willing=
 to =20
> wait until next week. =20
> =20
> On =46ri, May 8, 2015 at 12:20 PM, Jordan Zimmerman < =20
> jordan=40jordanzimmerman.com> wrote: =20
> I=E2=80=99d really appreciate the script. I can then add it to the wiki=
 as a step =20
> in the release process. =20
> =20
> =20
> =20
> On May 8, 2015 at 12:19:16 PM, Mike Drob (madrob=40cloudera.com) wrote:=
 =20
> =20
> All of the steps are currently manual. I can take some time to automate=
 =20
> them and submit a PR with a script in dev-tools folder. =20
> =20
> The general process is: =20
> 1. git checkout refs/tags/apache-curator-OLD =20
> 2. mvn clean package -DskipTests =20
> 3. mv **/*.jar ../OLD =20
> =20
> Repeat same steps for new. =20
> =20
> Compare each jar pairwise: =20
> =20
> for i in OLD/*; do f=3D=60basename =24i =7C sed -e 's/=5B0-9=5D.//g' -e=
 's/-jar//'=60 ; =20
> japi-compliance-checker OLD/=24=7Bf=7D-OLD.jar NEW/=24=7Bf=7D-NEW.jar; =
done =20
> =20
> replacing OLD and NEW as appropriate with the version numbers. The outp=
ut =20
> will be in the compat=5Freports directory. =20
> =20
> =20
> This will check for backward compatibility. To check forward compatibil=
ity =20
> (e.g. 2.7.1 -> 2.7.2), then run it with OLD and NEW reversed. =20
> =20
> Mike =20
> =20
> =20
> On =46ri, May 8, 2015 at 12:03 PM, Jordan Zimmerman < =20
> jordan=40jordanzimmerman.com> wrote: =20
> Mike, =20
> =20
> Do you manually run the compliance checker on each JAR or do you have a=
 =20
> script=3F If you have a script, please share and I=E2=80=99ll put it on=
 the wiki. =20
> =20
> -Jordan =20
> =20
> =20
> =20
> On May 7, 2015 at 6:31:50 PM, Mike Drob (madrob=40cloudera.com) wrote: =
=20
> =20
> I'm using the java-api-compatibility-checker =5B1=5D =20
> =20
> I think I ran into a bug with it, so I had to run using Java 7 instead =
of =20
> Java 8, but that probably does not affect the results. =20
> =20
> At a minimum, it should be possible to convert JsonNode -> String -> =20
> (other) JsonNode, for both directions. I'm not sure that is desirable w=
hen =20
> the stated intent was for performance reasons, though. =20
> =20
> =5B1=5D https://github.com/lvc/japi-compliance-checker/ =20
> =20
> On Thu, May 7, 2015 at 4:29 PM, Cameron McKenzie <mckenzie.cam=40gmail.=
com> =20
> wrote: =20
> =20
> > Good pickup Mike, =20
> > What is the tool that you're using to detect this incompatibilities=3F=
 It =20
> > would be good for someone to run it on pull requests prior to them be=
ing =20
> > merged to the master branch. =20
> > =20
> > I'm not familiar with the x-discovery stuff, so I can't really commen=
t on =20
> > whether there's a way of doing the change without breaking compatibil=
ity. =20
> > Is it possible to create a org.codehaus.jackson.JsonNode from a =20
> > com.fasterxml.jackson.databind.JsonNode=3F =20
> > Not easily I imagine. =20
> > =20
> > I agree though that we should be moving this to 3.0.0 if we cannot ma=
ke =20
> the =20
> > change without breaking compatibility. =20
> > cheers =20
> > =20
> > =20
> > =20
> > On Thu, May 7, 2015 at 10:41 AM, Mike Drob <madrob=40cloudera.com> wr=
ote: =20
> > =20
> > > -1 non-binding =20
> > > =20
> > > We break backward compatibility in this release. Here are reports r=
un =20
> via =20
> > > the java-api-compliance-checker: =20
> > > =20
> > > =20
> > =20
> http://people.apache.org/=7Emdrob/curator-2.8.0/x-discovery-server-back=
.html =20
> > > http://people.apache.org/=7Emdrob/curator-2.8.0/x-rpc-back.html =20
> > > =20
> > > The rest of the modules came up clean. =20
> > > =20
> > > The changes in the discovery server came from CURATOR-186. User cod=
e =20
> with =20
> > > references to DiscoveryContext is going to end up broken at both th=
e =20
> > source =20
> > > and binary levels. =20
> > > =20
> > > I think the rpc changes are all a result of the same JIRA removing =
the =20
> > > jackson dependency. =20
> > > =20
> > > To address this, we can revert this change, and re-apply it for the=
 3.0 =20
> > > release. =20
> > > =20
> > > Mike =20
> > > =20
> > > =20
> > > =20
> > > On Wed, May 6, 2015 at 1:24 AM, Ashish <paliwalashish=40gmail.com> =
=20
> wrote: =20
> > > =20
> > > > +1 (non-binding) =20
> > > > =20
> > > > Ran the build and test cases, work good =20
> > > > =20
> > > > On Wed, May 6, 2015 at 6:05 AM, Jordan Zimmerman < =20
> randgalt=40apache.org> =20
> > > > wrote: =20
> > > > > Hello, =20
> > > > > =20
> > > > > This is the vote for Apache Curator version 2.8.0 =20
> > > > > =20
> > > > > *** Please download, test and vote within approx. 72 hours =20
> > > > > =20
> > > > > Note that we are voting upon the source (tag) and binaries are =
=20
> > > > > provided for convenience. =20
> > > > > =20
> > > > > Link to release notes: =20
> > > > > =20
> > > > =20
> > > =20
> > =20
> https://issues.apache.org/jira/secure/ReleaseNote.jspa=3FprojectId=3D12=
314425&version=3D12329300 =20
> > > > > =20
> > > > > Staging repo: =20
> > > > > https://dist.apache.org/repos/dist/dev/curator/2.8.0 =20
> > > > > =20
> > > > > Binary artifacts: =20
> > > > > =20
> > > > =20
> > > =20
> > =20
> https://repository.apache.org/content/repositories/orgapachecurator-101=
1/ =20
> > > > > =20
> > > > > The tag to be voted upon: =20
> > > > > =20
> > > > =20
> > > =20
> > =20
> https://git-wip-us.apache.org/repos/asf=3Fp=3Dcurator.git;a=3Dtag;h=3D2=
2a045c39e08f10273b057c384c62db2337edac8 =20
> > > > > =20
> > > > > Curator's KEYS file containing PGP keys we use to sign the rele=
ase: =20
> > > > > http://www.apache.org/dist/curator/KEYS =20
> > > > > =20
> > > > > =5B =5D +1 approve =20
> > > > > =5B =5D +0 no opinion =20
> > > > > =5B =5D -1 disapprove (and reason why) =20
> > > > =20
> > > > =20
> > > > =20
> > > > -- =20
> > > > thanks =20
> > > > ashish =20
> > > > =20
> > > > Blog: http://www.ashishpaliwal.com/blog =20
> > > > My Photo Galleries: http://www.pbase.com/ashishpaliwal =20
> > > > =20
> > > =20
> > =20
> =20
> =20
> =20


-- =20
Sean =20

--554cfcb0_625558ec_95b--