Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Date: Fri, 8 May 2015 12:20:18 -0500
From: Jordan Zimmerman <jordan@jordanzimmerman.com>
To: Mike Drob <madrob@cloudera.com>
Cc: dev@curator.apache.org
Message-ID: <etPan.554cf052.6b8b4567.95b@Jordans-MacBook-Pro-2.local>
In-Reply-To: 
 <CAFAMeYK4YqOv+9DabVpZsq1xF5APBw=MJuEncfkmpB2XqE8vOA@mail.gmail.com>
References: 
 <CABRiMSH6dOWcdC6CdGUq6LTYQ4C_cSTskF+SOZ=t4XZzqZBFLw@mail.gmail.com>
 <CA++geaDzPrgmCZrADJOO8JPTAduJVCfWL20QbbLG6BxkOskA-g@mail.gmail.com>
 <CAFAMeY+BGo66hez8ffRt_f0DnvCxvp1v_YaA6jgQ1=rmj_BTMQ@mail.gmail.com>
 <CANykdubXSyO1qJn5ucsvUz3WRtx1wVLk3XYCCGZfpU9inmv2OA@mail.gmail.com>
 <CAFAMeYKeyYwxO-+D209AvuqkUiTkZtcsJ0PycPuOc3VdzEFJOw@mail.gmail.com>
 <etPan.554cec4b.643c9869.15b@Jordans-MacBook-Pro-2.local>
 <CAFAMeYK4YqOv+9DabVpZsq1xF5APBw=MJuEncfkmpB2XqE8vOA@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Curator version 2.8.0
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="554cf052_327b23c6_95b"

--554cf052_327b23c6_95b
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

I=E2=80=99d really appreciate the script. I can then add it to the wiki a=
s a step in the release process.


On May 8, 2015 at 12:19:16 PM, Mike Drob (madrob=40cloudera.com) wrote:

All of the steps are currently manual. I can take some time to automate t=
hem and submit a PR with a script in dev-tools folder.

The general process is:
1. git checkout refs/tags/apache-curator-OLD
2. mvn clean package -DskipTests
3. mv **/*.jar ../OLD

Repeat same steps for new.

Compare each jar pairwise:

for i in OLD/*; do f=3D=60basename =24i =7C sed -e 's/=5B0-9=5D.//g' -e '=
s/-jar//'=60 ; japi-compliance-checker OLD/=24=7Bf=7D-OLD.jar NEW/=24=7Bf=
=7D-NEW.jar; done

replacing OLD and NEW as appropriate with the version numbers. The output=
 will be in the compat=5Freports directory.


This will check for backward compatibility. To check forward compatibilit=
y (e.g. 2.7.1 -> 2.7.2), then run it with OLD and NEW reversed.

Mike


On =46ri, May 8, 2015 at 12:03 PM, Jordan Zimmerman <jordan=40jordanzimme=
rman.com> wrote:
Mike,

Do you manually run the compliance checker on each JAR or do you have a s=
cript=3F If you have a script, please share and I=E2=80=99ll put it on th=
e wiki.

-Jordan


On May 7, 2015 at 6:31:50 PM, Mike Drob (madrob=40cloudera.com) wrote:

I'm using the java-api-compatibility-checker =5B1=5D

I think I ran into a bug with it, so I had to run using Java 7 instead of=

Java 8, but that probably does not affect the results.

At a minimum, it should be possible to convert JsonNode -> String ->
(other) JsonNode, for both directions. I'm not sure that is desirable whe=
n
the stated intent was for performance reasons, though.

=5B1=5D https://github.com/lvc/japi-compliance-checker/

On Thu, May 7, 2015 at 4:29 PM, Cameron McKenzie <mckenzie.cam=40gmail.co=
m>
wrote:

> Good pickup Mike,
> What is the tool that you're using to detect this incompatibilities=3F =
It
> would be good for someone to run it on pull requests prior to them bein=
g
> merged to the master branch.
>
> I'm not familiar with the x-discovery stuff, so I can't really comment =
on
> whether there's a way of doing the change without breaking compatibilit=
y.
> Is it possible to create a org.codehaus.jackson.JsonNode from a
> com.fasterxml.jackson.databind.JsonNode=3F
> Not easily I imagine.
>
> I agree though that we should be moving this to 3.0.0 if we cannot make=
 the
> change without breaking compatibility.
> cheers
>
>
>
> On Thu, May 7, 2015 at 10:41 AM, Mike Drob <madrob=40cloudera.com> wrot=
e:
>
> > -1 non-binding
> >
> > We break backward compatibility in this release. Here are reports run=
 via
> > the java-api-compliance-checker:
> >
> >
> http://people.apache.org/=7Emdrob/curator-2.8.0/x-discovery-server-back=
.html
> > http://people.apache.org/=7Emdrob/curator-2.8.0/x-rpc-back.html
> >
> > The rest of the modules came up clean.
> >
> > The changes in the discovery server came from CURATOR-186. User code =
with
> > references to DiscoveryContext is going to end up broken at both the
> source
> > and binary levels.
> >
> > I think the rpc changes are all a result of the same JIRA removing th=
e
> > jackson dependency.
> >
> > To address this, we can revert this change, and re-apply it for the 3=
.0
> > release.
> >
> > Mike
> >
> >
> >
> > On Wed, May 6, 2015 at 1:24 AM, Ashish <paliwalashish=40gmail.com> wr=
ote:
> >
> > > +1 (non-binding)
> > >
> > > Ran the build and test cases, work good
> > >
> > > On Wed, May 6, 2015 at 6:05 AM, Jordan Zimmerman <randgalt=40apache=
.org>
> > > wrote:
> > > > Hello,
> > > >
> > > > This is the vote for Apache Curator version 2.8.0
> > > >
> > > > *** Please download, test and vote within approx. 72 hours
> > > >
> > > > Note that we are voting upon the source (tag) and binaries are
> > > > provided for convenience.
> > > >
> > > > Link to release notes:
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa=3FprojectId=3D12=
314425&version=3D12329300
> > > >
> > > > Staging repo:
> > > > https://dist.apache.org/repos/dist/dev/curator/2.8.0
> > > >
> > > > Binary artifacts:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecurator-101=
1/
> > > >
> > > > The tag to be voted upon:
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf=3Fp=3Dcurator.git;a=3Dtag;h=3D2=
2a045c39e08f10273b057c384c62db2337edac8
> > > >
> > > > Curator's KEYS file containing PGP keys we use to sign the releas=
e:
> > > > http://www.apache.org/dist/curator/KEYS
> > > >
> > > > =5B =5D +1 approve
> > > > =5B =5D +0 no opinion
> > > > =5B =5D -1 disapprove (and reason why)
> > >
> > >
> > >
> > > --
> > > thanks
> > > ashish
> > >
> > > Blog: http://www.ashishpaliwal.com/blog
> > > My Photo Galleries: http://www.pbase.com/ashishpaliwal
> > >
> >
>


--554cf052_327b23c6_95b--