Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: madrob <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-77-curator@git.apache.org>
In-Reply-To: <git-pr-77-curator@git.apache.org>
Subject: [GitHub] curator pull request: [CURATOR-215] Support async
 multi/transactio...
Content-Type: text/plain
Message-Id: <20150512193230.0E722E08E9@git1-us-west.apache.org>
Date: Tue, 12 May 2015 19:32:30 +0000 (UTC)

Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/77#discussion_r30171284
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java ---
    @@ -0,0 +1,45 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.curator.framework.api.transaction;
    +
    +import org.apache.curator.framework.CuratorFramework;
    +import java.util.List;
    +
    +public interface CuratorMultiTransactionMain
    +{
    +    /**
    +     * Commit the given operations as a single transaction. Create the
    +     * operation instances via {@link CuratorFramework#transactionOp()}
    +     *
    +     * @param operations operations that make up the transaction.
    +     * @return result details
    +     * @throws Exception errors
    +     */
    +    List<CuratorTransactionResult> forOperations(CuratorOp... operations) throws Exception;
    +
    +    /**
    +     * Commit the given operations as a single transaction. Create the
    +     * operation instances via {@link CuratorFramework#transactionOp()}
    +     *
    +     * @param operations operations that make up the transaction.
    +     * @return result details
    --- End diff --
    
    Expand the javadoc here, please. For example, I was surprised to read the code and discover that this call returns null if the operation is in the background.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---