Return-Path: 
 <dev-return-4092-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 50A89181EC
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Tue, 12 May 2015 17:01:00 +0000 (UTC)
Received: (qmail 31492 invoked by uid 500); 12 May 2015 17:01:00 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 31451 invoked by uid 500); 12 May 2015 17:01:00 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 31438 invoked by uid 99); 12 May 2015 17:00:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 May 2015 17:00:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 7C596E08E9; Tue, 12 May 2015 17:00:59 +0000 (UTC)
From: madrob <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-77-curator@git.apache.org>
In-Reply-To: <git-pr-77-curator@git.apache.org>
Subject: [GitHub] curator pull request: [CURATOR-215] Support async
 multi/transactio...
Content-Type: text/plain
Message-Id: <20150512170059.7C596E08E9@git1-us-west.apache.org>
Date: Tue, 12 May 2015 17:00:59 +0000 (UTC)

Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/77#discussion_r30155545
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/transaction/CuratorMultiTransactionMain.java ---
    @@ -0,0 +1,45 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.curator.framework.api.transaction;
    +
    +import org.apache.curator.framework.CuratorFramework;
    +import java.util.List;
    +
    +public interface CuratorMultiTransactionMain
    +{
    +    /**
    +     * Commit the given operations as a single transaction. Create the
    +     * operation instances via {@link CuratorFramework#transactionOp()}
    +     *
    +     * @param operations operations that make up the transaction.
    +     * @return result details
    +     * @throws Exception errors
    +     */
    +    List<CuratorTransactionResult> forOperations(CuratorOp... operations) throws Exception;
    +
    +    /**
    +     * Commit the given operations as a single transaction. Create the
    +     * operation instances via {@link CuratorFramework#transactionOp()}
    +     *
    +     * @param operations operations that make up the transaction.
    +     * @return result details
    +     * @throws Exception errors
    +     */
    +    List<CuratorTransactionResult> forOperations(List<CuratorOp> operations) throws Exception;
    --- End diff --
    
    If users believe that order matters, then they can use a list. If they don't care, then it might make sense for them to use a Set, or in Java8 a Stream. Well, a finite Stream. Also, would be more flexible to use `<? extends CuratorOp>`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---