Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 488F517B99 for ; Mon, 11 May 2015 04:09:51 +0000 (UTC) Received: (qmail 91622 invoked by uid 500); 11 May 2015 04:09:51 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 91580 invoked by uid 500); 11 May 2015 04:09:51 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Delivered-To: moderator for dev@curator.apache.org Received: (qmail 83522 invoked by uid 99); 11 May 2015 04:03:27 -0000 From: cammckenzie To: dev@curator.apache.org Reply-To: dev@curator.apache.org References: In-Reply-To: Subject: [GitHub] curator pull request: Curator 161 Content-Type: text/plain Message-Id: <20150511040327.59B14DFA6D@git1-us-west.apache.org> Date: Mon, 11 May 2015 04:03:27 +0000 (UTC) Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/56#discussion_r30012206 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/RemoveWatchesBuilder.java --- @@ -0,0 +1,29 @@ +package org.apache.curator.framework.api; --- End diff -- Looking at the local case again, I think it's actually just client.getZookeeper() that needs to be used. I notice that this is how it's used in all of the performBackgroundOperation calls, but there are no checks for null pointers in this case. Is there a reason for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---