curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 161
Date Wed, 20 May 2015 01:46:36 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/56#discussion_r30665705
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/FailedDeleteManager.java
---
    @@ -19,45 +19,18 @@
     package org.apache.curator.framework.imps;
     
     import org.apache.curator.framework.CuratorFramework;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
     
    -class FailedDeleteManager
    +class FailedDeleteManager extends FailedOperationManager<String>
     {
    -    private final Logger log = LoggerFactory.getLogger(getClass());
    -    private final CuratorFramework client;
    -    
    -    volatile FailedDeleteManagerListener debugListener = null;
    --- End diff --
    
    nit: mark @VisibleForTesting


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message