curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-215] Support async multi/transactio...
Date Tue, 12 May 2015 18:40:18 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/77#discussion_r30166320
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorTransactionImpl.java
---
    @@ -188,19 +169,45 @@ private CuratorTransactionResult makeCuratorResult(OpResult opResult,
CuratorMul
     
                 case ZooDefs.OpCode.create:
                 {
    -                OpResult.CreateResult       createResult = (OpResult.CreateResult)opResult;
    +                OpResult.CreateResult createResult = (OpResult.CreateResult)opResult;
                     resultPath = client.unfixForNamespace(createResult.getPath());
                     break;
                 }
     
                 case ZooDefs.OpCode.setData:
                 {
    -                OpResult.SetDataResult      setDataResult = (OpResult.SetDataResult)opResult;
    +                OpResult.SetDataResult setDataResult = (OpResult.SetDataResult)opResult;
                     resultStat = setDataResult.getStat();
                     break;
                 }
             }
     
    -        return new CuratorTransactionResult(metadata.type, metadata.forPath, resultPath,
resultStat);
    +        return new CuratorTransactionResult(metadata.getType(), metadata.getForPath(),
resultPath, resultStat);
    +    }
    +
    +    private List<OpResult> doOperation(AtomicBoolean firstTime) throws Exception
    +    {
    +        boolean localFirstTime = firstTime.getAndSet(false);
    +        if ( !localFirstTime )
    +        {
    +            // TODO
    --- End diff --
    
    That's been in there a long time. I should just remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message