curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 161
Date Mon, 11 May 2015 04:03:27 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/56#discussion_r30012206
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/RemoveWatchesBuilder.java
---
    @@ -0,0 +1,29 @@
    +package org.apache.curator.framework.api;
    --- End diff --
    
    Looking at the local case again, I think it's actually just client.getZookeeper() that
needs to be used. I notice that this is how it's used in all of the performBackgroundOperation
calls, but there are no checks for null pointers in this case. Is there a reason for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message