Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B2DF1751B for ; Tue, 7 Apr 2015 16:39:28 +0000 (UTC) Received: (qmail 20129 invoked by uid 500); 7 Apr 2015 16:39:12 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 20081 invoked by uid 500); 7 Apr 2015 16:39:12 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 20068 invoked by uid 99); 7 Apr 2015 16:39:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 16:39:12 +0000 Date: Tue, 7 Apr 2015 16:39:12 +0000 (UTC) From: "Mike Drob (JIRA)" To: dev@curator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CURATOR-200) Proposal: Remove references to guava library from public APIs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CURATOR-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483457#comment-14483457 ] Mike Drob commented on CURATOR-200: ----------------------------------- Since Guava is Apache licensed, we can always just copy a few classes over to 1) ensure API stability, 2) drop the external dependency. > Proposal: Remove references to guava library from public APIs > ------------------------------------------------------------- > > Key: CURATOR-200 > URL: https://issues.apache.org/jira/browse/CURATOR-200 > Project: Apache Curator > Issue Type: Improvement > Components: Framework > Reporter: Mike Drob > Fix For: TBD > > > There was a good discussion on the mailing list: http://curator.markmail.org/thread/yjete2ozm32jmz5u > The critical portion copied here: > {quote} > The problem classes that I have found are: > * curator-framework: org.apache.curator.framework.listen.ListenerContainer : method forEach takes a parameter of type com.google.common.base.Function > * curator-framework: org.apache.curator.framework.api.transaction.CuratorTransactionResult : method ofTypeAndPath returns com.google.common.base.Predicate > * curator-x-discovery-server: org.apache.curator.x.discovery.server.contexts.GenericDiscoveryContext : constructor takes param of type com.google.common.reflect.TypeToken > * curator-x-discovery: org.apache.curator.x.discovery.InstanceFilter : inherits from com.google.common.base.Predicate > {quote} > In the ensuing discussion, it sounded like we'd need to get started on an implementation before we had enough information to determine whether the changes are too intrusive or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)