curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From busbey <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-164 prevent phantom services
Date Fri, 17 Apr 2015 03:30:15 GMT
Github user busbey commented on a diff in the pull request:

    https://github.com/apache/curator/pull/72#discussion_r28567933
  
    --- Diff: curator-x-discovery/src/test/java/org/apache/curator/x/discovery/TestServiceDiscovery.java
---
    @@ -297,4 +304,70 @@ public void testNoServerOnStart() throws Exception
                 }
             }
         }
    +
    +    // CURATOR-164
    +    @Test
    +    public void testUnregisterService() throws Exception {
    +        final String name = "name";
    +
    +        final CountDownLatch restartLatch = new CountDownLatch(1);
    +        final CountDownLatch serializeLatch = new CountDownLatch(1);
    --- End diff --
    
    you made this latch, but then used a sleep call to wait for the serialization to finish.
better ot switch to using this latch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message