curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cheddar <...@git.apache.org>
Subject [GitHub] curator pull request: Make PathChildrenCache ignore old versions
Date Tue, 03 Mar 2015 22:01:42 GMT
GitHub user cheddar opened a pull request:

    https://github.com/apache/curator/pull/68

    Make PathChildrenCache ignore old versions

    Currently, PathChildrenCache, when set to cache data, can potentially cache stale versions
of files.  In some client code, we are seeing CHILD_UPDATE events being delivered with out-of-order
versions.
    
    This PR is for a fix to the logic for what to do with old `Stat` objects.  That said,
I looked over the unit tests and wasn't able to come up with a great strategy for verifying
this behavior.  It would be nice to be able to mock something out so that I just feed out-of-order
events to the method in question, but I'm not seeing that injection point.  Any ideas on how
this could be easily UT'd?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cheddar/curator CURATOR-191

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
    
----
commit fed3068e9281b3e3b1e8e293218672fa2a0b2388
Author: Eric Tschetter <cheddar@yahoo-inc.com>
Date:   2015-03-03T21:58:49Z

    Make PathChildrenCache ignore old versions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message