curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-173
Date Thu, 05 Mar 2015 17:21:23 GMT
Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/67#discussion_r25882210
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/LockSchema.java
---
    @@ -0,0 +1,22 @@
    +package org.apache.curator.framework.recipes.locks;
    +
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +import com.google.common.collect.Sets;
    +
    +public class LockSchema {
    +    private final Set<String> paths;
    +
    +    public LockSchema() {
    +        paths = new HashSet<String>();
    +    }
    +
    +    public LockSchema(Set<String> paths) {
    +        this.paths = Sets.newHashSet(paths);
    +    }
    +
    +    public Set<String> getPaths() {
    +        return Sets.newHashSet(paths);
    +    }
    +}
    --- End diff --
    
    This doesn't look like it adds a lot of value as a concrete class.  I would either just
pass the set directly to the reaper, or else turn this into an interface.  You could also
use Iterable instead of Set since you don't really depend on Set semantics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message