Return-Path: 
 <dev-return-3701-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 26A6B173C7
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Wed, 25 Feb 2015 09:28:05 +0000 (UTC)
Received: (qmail 20602 invoked by uid 500); 25 Feb 2015 09:28:05 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 20558 invoked by uid 500); 25 Feb 2015 09:28:05 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 20407 invoked by uid 99); 25 Feb 2015 09:28:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Feb 2015 09:28:04 +0000
Date: Wed, 25 Feb 2015 09:28:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@curator.apache.org
Message-ID: <JIRA.12763294.1419276626000.9709.1424856484917@Atlassian.JIRA>
In-Reply-To: <JIRA.12763294.1419276626000@Atlassian.JIRA>
References: <JIRA.12763294.1419276626000@Atlassian.JIRA>
 <JIRA.12763294.1419276626177@arcas>
Subject: [jira] [Commented] (CURATOR-173) InterProcessSemaphoreV2 nodes not
 reapable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CURATOR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336285#comment-14336285 ] 

ASF GitHub Bot commented on CURATOR-173:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/67#discussion_r25326832
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/LockSchema.java ---
    @@ -0,0 +1,22 @@
    +package org.apache.curator.framework.recipes.locks;
    +
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +import com.google.common.collect.Sets;
    +
    +public class LockSchema {
    +    private final Set<String> paths;
    +
    +    public LockSchema() {
    +        paths = new HashSet<String>();
    --- End diff --
    
    Just nit picking but this should probably be Sets.newHashSet() for consistency.


> InterProcessSemaphoreV2 nodes not reapable
> ------------------------------------------
>
>                 Key: CURATOR-173
>                 URL: https://issues.apache.org/jira/browse/CURATOR-173
>             Project: Apache Curator
>          Issue Type: Bug
>            Reporter: David Kesler
>            Assignee: Jordan Zimmerman
>
> The curator documentation recommends using a reaper or childreaper to clean up stale lock nodes.  This worked for InterProcessSemaphore locks.  However lock paths that are created by InterProcessSemaphoreV2 cannot be reaped.  The V2 recipe creates two subnodes beneath the lock node, 'locks' and 'leases', which are never cleaned up by the recipe.  This ensures that the lock node itself will never be empty and thus never reaped.  It doesn't seem like there's any safe way of handling cleaning up after an InterProcessSemaphoreV2 using canonical curator recipes.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)