Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: dkesler <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-66-curator@git.apache.org>
In-Reply-To: <git-pr-66-curator@git.apache.org>
Subject: [GitHub] curator pull request: Curator 187
Content-Type: text/plain
Message-Id: <20150210003521.6C4FADFD59@git1-us-west.apache.org>
Date: Tue, 10 Feb 2015 00:35:21 +0000 (UTC)

Github user dkesler commented on a diff in the pull request:

    https://github.com/apache/curator/pull/66#discussion_r24379974
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/ChildReaper.java ---
    @@ -173,32 +191,40 @@ public boolean removePath(String path)
             return paths.remove(PathUtils.validatePath(path));
         }
     
    -    private static ScheduledExecutorService newExecutorService()
    +    public static ScheduledExecutorService newExecutorService()
         {
             return ThreadUtils.newFixedThreadScheduledPool(2, "ChildReaper");
         }
     
         private void doWork()
         {
    -        for ( String path : paths )
    +        if (shouldDoWork())
    --- End diff --
    
    That race condition is already present with the leader election in the Reaper itself as it could lose leadership after scheduling a check for some time in the future, so this is at least no worse than the current state of things.  And the race condition doesn't matter too much anyway as the reapers don't use leader election for correctness, but rather because otherwise you get a bunch of logspam about trying to delete already deleted nodes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---