curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-173
Date Wed, 25 Feb 2015 09:27:29 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/67#discussion_r25326832
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/LockSchema.java
---
    @@ -0,0 +1,22 @@
    +package org.apache.curator.framework.recipes.locks;
    +
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +import com.google.common.collect.Sets;
    +
    +public class LockSchema {
    +    private final Set<String> paths;
    +
    +    public LockSchema() {
    +        paths = new HashSet<String>();
    --- End diff --
    
    Just nit picking but this should probably be Sets.newHashSet() for consistency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message