curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-157 Avoid stack traces on close
Date Thu, 19 Feb 2015 16:05:49 GMT
Github user madrob commented on the pull request:

    https://github.com/apache/curator/pull/51#issuecomment-75078668
  
    Ok, I think I got myself confused between the two close operations.
    
    Can you add a test (probably with an artificial delay to ensure ordering) that would fail
before your patch and pass after to make sure that we properly handle this? Sorry to push
back on this, but I'm not sure anymore of my own ability to understand the code 100%.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message