curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dkesler <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 187
Date Tue, 10 Feb 2015 00:15:22 GMT
Github user dkesler commented on a diff in the pull request:

    https://github.com/apache/curator/pull/66#discussion_r24378993
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/Reaper.java
---
    @@ -333,7 +355,20 @@ public void notLeader()
                     reapingIsActive.set(false);
                 }
             };
    -        localLeaderLatch.addListener(listener);
    -        return localLeaderLatch;
    +        leaderLatch.addListener(listener);
    +
    +        reapingIsActive.set(leaderLatch.hasLeadership());
    --- End diff --
    
    schedule() gets called on the individual paths in activePaths.  Since this method only
gets called during the construction of the Reaper, there won't be any activePaths to schedule.
When those paths get added later, they will get scheduled as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message