curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 187
Date Mon, 09 Feb 2015 23:20:12 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/66#discussion_r24375781
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/Reaper.java
---
    @@ -333,7 +355,20 @@ public void notLeader()
                     reapingIsActive.set(false);
                 }
             };
    -        localLeaderLatch.addListener(listener);
    -        return localLeaderLatch;
    +        leaderLatch.addListener(listener);
    +
    +        reapingIsActive.set(leaderLatch.hasLeadership());
    +    }
    +
    +    private static LeaderLatch makeLeaderLatchIfPathNotNull(CuratorFramework client,
String leaderPath)
    --- End diff --
    
    Any reason for this to be static?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message