Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: Randgalt <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-62-curator@git.apache.org>
In-Reply-To: <git-pr-62-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-111 - Modified the
 authorization han...
Content-Type: text/plain
Message-Id: <20150113120934.E1A6892D917@tyr.zones.apache.org>
Date: Tue, 13 Jan 2015 12:09:34 +0000 (UTC)

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/62#discussion_r22857953
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java ---
    @@ -380,16 +383,6 @@ public String getNamespace()
                 return namespace;
             }
     
    -        public String getAuthScheme()
    --- End diff --
    
    I think these methods should stay and be marked as deprecated so this is not a breaking change. The old methods can either return return the first auth or throw an error if there is more than 1 auth.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---