Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: dragonsinth <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-60-curator@git.apache.org>
In-Reply-To: <git-pr-60-curator@git.apache.org>
Subject: [GitHub] curator pull request: Use Curator in thread names.
Content-Type: text/plain
Message-Id: <20150106002436.3AC11A40F3C@tyr.zones.apache.org>
Date: Tue,  6 Jan 2015 00:24:36 +0000 (UTC)

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/60#discussion_r22500625
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorTempFrameworkImpl.java ---
    @@ -98,7 +99,15 @@ private synchronized void openConnectionIfNeeded() throws Exception
             if ( cleanup == null )
             {
                 ThreadFactory threadFactory = factory.getThreadFactory();
    -            cleanup = (threadFactory != null) ? Executors.newScheduledThreadPool(1, threadFactory) : Executors.newScheduledThreadPool(1);
    +
    --- End diff --
    
    Maybe we want a ThreadUtils.newNonDaemonThreadFactory() to replace this?
    But LGTM either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---