curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-111) CuratorFramework.Builder should allow adding multiple auths
Date Tue, 13 Jan 2015 12:12:34 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275120#comment-14275120
] 

ASF GitHub Bot commented on CURATOR-111:
----------------------------------------

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/62#discussion_r22858035
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
---
    @@ -163,8 +166,8 @@ public CuratorTempFramework buildTemp(long inactiveThreshold, TimeUnit
unit)
              */
             public Builder authorization(String scheme, byte[] auth)
             {
    -            this.authScheme = scheme;
    -            this.authValue = (auth != null) ? Arrays.copyOf(auth, auth.length) : null;
    +            this.authInfos = Lists.newArrayList();
    --- End diff --
    
    This should call authorization(List<AuthInfo> authInfos). E.g.
    
    ```
    return authorization(Lists.newArrayList(new AuthInfo(scheme, (auth != null) ? Arrays.copyOf(auth,
auth.length) : null)));
    ```


> CuratorFramework.Builder should allow adding multiple auths
> -----------------------------------------------------------
>
>                 Key: CURATOR-111
>                 URL: https://issues.apache.org/jira/browse/CURATOR-111
>             Project: Apache Curator
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Karthik Kambatla
>            Assignee: Jordan Zimmerman
>             Fix For: 2.7.1
>
>
> Currently, one can add a single authentication scheme/bytes when building CuratorFramework.
It would be handy to add multiple.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message