curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-111) CuratorFramework.Builder should allow adding multiple auths
Date Sun, 11 Jan 2015 01:37:34 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272758#comment-14272758
] 

ASF GitHub Bot commented on CURATOR-111:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22763552
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo
= new AtomicReference<AuthInfo>();
    --- End diff --
    
    No, I don't see any issues with it either. Just wondering why it was previously an AtomicReference.
Anyway, I think this looks good to merge. Thanks.


> CuratorFramework.Builder should allow adding multiple auths
> -----------------------------------------------------------
>
>                 Key: CURATOR-111
>                 URL: https://issues.apache.org/jira/browse/CURATOR-111
>             Project: Apache Curator
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Karthik Kambatla
>            Assignee: Jordan Zimmerman
>             Fix For: TBD
>
>
> Currently, one can add a single authentication scheme/bytes when building CuratorFramework.
It would be handy to add multiple.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message