curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-111 - Modified the authorization han...
Date Tue, 13 Jan 2015 12:11:51 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/62#discussion_r22858035
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
---
    @@ -163,8 +166,8 @@ public CuratorTempFramework buildTemp(long inactiveThreshold, TimeUnit
unit)
              */
             public Builder authorization(String scheme, byte[] auth)
             {
    -            this.authScheme = scheme;
    -            this.authValue = (auth != null) ? Arrays.copyOf(auth, auth.length) : null;
    +            this.authInfos = Lists.newArrayList();
    --- End diff --
    
    This should call authorization(List<AuthInfo> authInfos). E.g.
    
    ```
    return authorization(Lists.newArrayList(new AuthInfo(scheme, (auth != null) ? Arrays.copyOf(auth,
auth.length) : null)));
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message