curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-111 - Modified the authorization han...
Date Tue, 13 Jan 2015 12:09:34 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/62#discussion_r22857953
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
---
    @@ -380,16 +383,6 @@ public String getNamespace()
                 return namespace;
             }
     
    -        public String getAuthScheme()
    --- End diff --
    
    I think these methods should stay and be marked as deprecated so this is not a breaking
change. The old methods can either return return the first auth or throw an error if there
is more than 1 auth.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message