curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-111: Add authorization(List<AuthInfo...
Date Tue, 06 Jan 2015 23:45:40 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22561607
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo
= new AtomicReference<AuthInfo>();
    --- End diff --
    
    @Randgalt, what was the rationale behind this being an AtomicReference originally? I can't
see any thread safety issues as it's only set in the constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message