curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gopikori <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-175: If zookeeper is down when disco...
Date Mon, 29 Dec 2014 15:19:24 GMT
Github user gopikori commented on the pull request:

    https://github.com/apache/curator/pull/58#issuecomment-68265604
  
    Not really. Because this was not a problem when the listener only considered the *RECONNECTED*
state. Before the fix, although the listener was being registered earlier, the call to *reRegisterServices()*
was prevented as the *if* condition ignored *CONNECTED* state. But now with the *RECONNECTED*
state added to the *if* condition, this sequence change becomes necessary. Reverting any of
the two changes causes multiple test cases failure. I hope I am clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message