curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Added new apis to add additional paths to Ch...
Date Tue, 09 Dec 2014 19:56:21 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/57#discussion_r21557355
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/ChildReaper.java
---
    @@ -104,11 +106,11 @@ public ChildReaper(CuratorFramework client, String path, Reaper.Mode
mode, Sched
         public ChildReaper(CuratorFramework client, String path, Reaper.Mode mode, ScheduledExecutorService
executor, int reapingThresholdMs, String leaderPath)
    --- End diff --
    
    There are already like 5 ctors. I didn't want to add more. At some point we can add a
builder. But, if ppl think it's worth it I can add it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message