Return-Path: 
 <dev-return-3424-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D481E17C96
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Sat, 22 Nov 2014 00:48:33 +0000 (UTC)
Received: (qmail 3948 invoked by uid 500); 22 Nov 2014 00:48:33 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 3897 invoked by uid 500); 22 Nov 2014 00:48:33 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 3885 invoked by uid 99); 22 Nov 2014 00:48:33 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Nov 2014 00:48:33 +0000
Date: Sat, 22 Nov 2014 00:48:33 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@curator.apache.org
Message-ID: <JIRA.12752193.1414859520000.557682.1416617313677@Atlassian.JIRA>
In-Reply-To: <JIRA.12752193.1414859520000@Atlassian.JIRA>
References: <JIRA.12752193.1414859520000@Atlassian.JIRA>
 <JIRA.12752193.1414859520878@arcas>
Subject: [jira] [Commented] (CURATOR-160) Support Dynamic Reconfig
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CURATOR-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221658#comment-14221658 ] 

ASF GitHub Bot commented on CURATOR-160:
----------------------------------------

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/53#discussion_r20752095
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/Configurable.java ---
    @@ -0,0 +1,29 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.curator.framework.api;
    +
    +public interface Configurable<T> {
    +
    +    /**
    +     * Sets the configuration version to use.
    +     * @param config The version of the configuration.
    +     * @throws Exception
    +     */
    +    Ensembleable<T> fromConfig(long config) throws Exception;
    --- End diff --
    
    right now, fromConfig() is required. It should be optional. i.e. I should be able to write:
    
    ```
    client.reconfig().leaving("").joining("").forEnsemble();
    ```


> Support Dynamic Reconfig
> ------------------------
>
>                 Key: CURATOR-160
>                 URL: https://issues.apache.org/jira/browse/CURATOR-160
>             Project: Apache Curator
>          Issue Type: Sub-task
>            Reporter: Jordan Zimmerman
>            Assignee: Ioannis Canellos
>             Fix For: 3.0.0
>
>
> ZooKeeper 3.5.0 added a new feature "Dynamic Reconfiguration". Curator needs to support this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)