Return-Path: 
 <dev-return-3429-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2A5C2104A8
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Sat, 22 Nov 2014 16:16:49 +0000 (UTC)
Received: (qmail 27220 invoked by uid 500); 22 Nov 2014 16:16:48 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 27179 invoked by uid 500); 22 Nov 2014 16:16:48 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 27168 invoked by uid 99); 22 Nov 2014 16:16:48 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Nov 2014 16:16:48 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 5AC54A0BD6D; Sat, 22 Nov 2014 16:16:48 +0000 (UTC)
From: iocanel <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-53-curator@git.apache.org>
In-Reply-To: <git-pr-53-curator@git.apache.org>
Subject: [GitHub] curator pull request: [CURATOR-160] Add builders and dsl for
 ZooKe...
Content-Type: text/plain
Message-Id: <20141122161648.5AC54A0BD6D@tyr.zones.apache.org>
Date: Sat, 22 Nov 2014 16:16:48 +0000 (UTC)

Github user iocanel commented on a diff in the pull request:

    https://github.com/apache/curator/pull/53#discussion_r20758041
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/Configurable.java ---
    @@ -0,0 +1,29 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.curator.framework.api;
    +
    +public interface Configurable<T> {
    +
    +    /**
    +     * Sets the configuration version to use.
    +     * @param config The version of the configuration.
    +     * @throws Exception
    +     */
    +    Ensembleable<T> fromConfig(long config) throws Exception;
    --- End diff --
    
    Right. Let me fix that!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---