curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-166) Make ZKPaths accept more than one child
Date Mon, 17 Nov 2014 23:06:34 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215350#comment-14215350
] 

ASF GitHub Bot commented on CURATOR-166:
----------------------------------------

Github user rfer commented on a diff in the pull request:

    https://github.com/apache/curator/pull/54#discussion_r20473248
  
    --- Diff: curator-client/src/main/java/org/apache/curator/utils/ZKPaths.java ---
    @@ -276,26 +282,26 @@ public static void deleteChildren(ZooKeeper zookeeper, String path,
boolean dele
             Collections.sort(sortedList);
             return sortedList;
         }
    -
    +    
         /**
    -     * Given a parent path and a child node, create a combined full path
    +     * Given a parent path and a list of children nodes, create a combined full path
          *
          * @param parent the parent
    -     * @param child  the child
    +     * @param children  the children
          * @return full path
          */
    -    public static String makePath(String parent, String child)
    +    public static String makePath(String parent, String... children)
    --- End diff --
    
    Yes, that makes sense. I updated the change. In order to avoid code duplication and multiple
StringBuilder instantiations, I've added a new auxiliary method that mutates a StringBuilder
passd as an argument.


> Make ZKPaths accept more than one child
> ---------------------------------------
>
>                 Key: CURATOR-166
>                 URL: https://issues.apache.org/jira/browse/CURATOR-166
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Ricardo Ferreira
>            Priority: Trivial
>
> ZKPaths currently only accepts one parent and one child nodes. It would be useful to
be able to create paths with more depth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message