curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-160] Add builders and dsl for ZooKe...
Date Sat, 22 Nov 2014 00:47:52 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/53#discussion_r20752095
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/Configurable.java
---
    @@ -0,0 +1,29 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.curator.framework.api;
    +
    +public interface Configurable<T> {
    +
    +    /**
    +     * Sets the configuration version to use.
    +     * @param config The version of the configuration.
    +     * @throws Exception
    +     */
    +    Ensembleable<T> fromConfig(long config) throws Exception;
    --- End diff --
    
    right now, fromConfig() is required. It should be optional. i.e. I should be able to write:
    
    ```
    client.reconfig().leaving("").joining("").forEnsemble();
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message