curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <>
Subject [GitHub] curator pull request: CURATOR-166: Allow ZKPaths to build paths wi...
Date Mon, 17 Nov 2014 17:42:29 GMT
Github user dragonsinth commented on a diff in the pull request:
    --- Diff: curator-client/src/main/java/org/apache/curator/utils/ ---
    @@ -276,26 +282,26 @@ public static void deleteChildren(ZooKeeper zookeeper, String path,
boolean dele
             return sortedList;
    -     * Given a parent path and a child node, create a combined full path
    +     * Given a parent path and a list of children nodes, create a combined full path
          * @param parent the parent
    -     * @param child  the child
    +     * @param children  the children
          * @return full path
    -    public static String makePath(String parent, String child)
    +    public static String makePath(String parent, String... children)
    --- End diff --
    I would probably make 2 overloads here:
    `makePath(String, String)`
    `makePath(String, String, String...)`
    1) Preserve binary compatibility; changing the last to a vararg breaks binary compat if
you don't recompile client code.
    2) Not introduce the extra array allocation for the most common 2-arg case.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message