Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: dragonsinth <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-42-curator@git.apache.org>
In-Reply-To: <git-pr-42-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-145: TreeCache should
 implement maxD...
Content-Type: text/plain
Message-Id: <20141020195247.590BF9D352B@tyr.zones.apache.org>
Date: Mon, 20 Oct 2014 19:52:47 +0000 (UTC)

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/42#discussion_r19108936
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java ---
    @@ -146,6 +147,17 @@ public Builder setExecutor(CloseableExecutorService executorService)
                 this.executorService = checkNotNull(executorService);
                 return this;
             }
    +
    +        /**
    +         * Sets the maximum depth to explore/watch.  A {@code maxDepth} of {@code 0} will watch only
    +         * the root node; a {@code maxDepth} of {@code 1} will watch the root node and its immediate
    +         * children. Default: {@code Integer.MAX_VALUE}
    +         */
    +        public Builder setMaxDepth(int maxDepth)
    --- End diff --
    
    Clarified the doc a little bit here to note that maxDepth = 0 is like NodeCache, and maxDepth = 1 is kind of like PathChildrenCache.  I don't think adding constants really adds enough clarity and value to justify more surface area.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---