curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-145) TreeCache should implement maxDepth
Date Mon, 20 Oct 2014 19:53:34 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177389#comment-14177389
] 

ASF GitHub Bot commented on CURATOR-145:
----------------------------------------

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/42#discussion_r19108936
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
    @@ -146,6 +147,17 @@ public Builder setExecutor(CloseableExecutorService executorService)
                 this.executorService = checkNotNull(executorService);
                 return this;
             }
    +
    +        /**
    +         * Sets the maximum depth to explore/watch.  A {@code maxDepth} of {@code 0}
will watch only
    +         * the root node; a {@code maxDepth} of {@code 1} will watch the root node and
its immediate
    +         * children. Default: {@code Integer.MAX_VALUE}
    +         */
    +        public Builder setMaxDepth(int maxDepth)
    --- End diff --
    
    Clarified the doc a little bit here to note that maxDepth = 0 is like NodeCache, and maxDepth
= 1 is kind of like PathChildrenCache.  I don't think adding constants really adds enough
clarity and value to justify more surface area.


> TreeCache should implement maxDepth
> -----------------------------------
>
>                 Key: CURATOR-145
>                 URL: https://issues.apache.org/jira/browse/CURATOR-145
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: Scott Blum
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message