curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CURATOR-140) Support the initial data for the node in InterProcessReadWriteLock
Date Wed, 29 Oct 2014 22:49:33 GMT


ASF GitHub Bot commented on CURATOR-140:

Github user cammckenzie commented on the pull request:
    Thanks for the patch, it looks good.  Would you be able to provide a unit test that covers
the new functionality?

> Support the initial data for the node in InterProcessReadWriteLock
> ------------------------------------------------------------------
>                 Key: CURATOR-140
>                 URL:
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: Azrael
>            Priority: Minor
> Currently, locks(writeLock, readLock) in InterProcessReadWriteLock use the InetAddress
for a initial data for the node, It is a little difficult to debug the lock owner as it shows
only IP. If the initial data for lock node can be set, participantNodes contains the given
information(hostname, id). So, it is easy  to debug participantNodes.
> {code}
> writeLock = InterProcessReadWriteLock.writeLock();
> Collection<String> nodes = writeLock.getParticipantNodes();
> for (String node: nodes) {
>     String nodeData = new String(client.getData().forPath(node));
> }
> {code} 
> {{nodeData}} should be the information which is given in argument.

This message was sent by Atlassian JIRA

View raw message