curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-145: TreeCache should implement maxD...
Date Mon, 20 Oct 2014 19:58:58 GMT
Github user dragonsinth commented on the pull request:

    https://github.com/apache/curator/pull/42#issuecomment-59829735
  
    I'm inclined to want to go with what we have and reserve Predicate as a future feature.
 I don't think anything here so far would make it harder / preclude adding it later.
    
    I have 2 main concerns over adding general Predicates that make me want to consider this
much more carefully.
    
    1) Running the predicate means passing control to user code on cache's event callback
/ mutation threads.
    2) An inconsistent predicate would be super weird and possibly corrupt internal state.
 What would happen if a predicate's behavior changed on the fly, or gave inconsistent answers
for the same node?
    
    The idea definitely has merit I'm just not really ready to take it on right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message