curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-145: TreeCache should implement maxD...
Date Mon, 20 Oct 2014 15:52:04 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/42#discussion_r19093513
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
    @@ -179,24 +191,34 @@ public static Builder newBuilder(CuratorFramework client, String
path)
             final AtomicReference<Stat> stat = new AtomicReference<Stat>();
             final AtomicReference<byte[]> data = new AtomicReference<byte[]>();
             final AtomicReference<ConcurrentMap<String, TreeNode>> children =
new AtomicReference<ConcurrentMap<String, TreeNode>>();
    +        final int depth;
     
             TreeNode(String path, TreeNode parent)
             {
                 this.path = path;
                 this.parent = parent;
    +            this.depth = parent == null ? 0 : parent.depth + 1;
             }
     
             private void refresh() throws Exception
             {
    -            outstandingOps.addAndGet(2);
    -            doRefreshData();
    -            doRefreshChildren();
    +            if (depth < maxDepth)
    --- End diff --
    
    This is an interesting idea. We could leave the integer based maxDepth in the builder
but have it create a Predicate internally. Then, have an alternate method in the builder that
takes an actual predicate. But, let's let @dragonsinth decide.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message