curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-151: SharedValue/SharedCount API upd...
Date Sat, 04 Oct 2014 02:09:23 GMT
Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/47#discussion_r18426996
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/shared/SharedValue.java
---
    @@ -225,11 +238,11 @@ public void close() throws IOException
             listeners.clear();
         }
     
    -    private synchronized void readValue() throws Exception
    +    private void readValue() throws Exception
    --- End diff --
    
    we might still want to synchronize to avoid multiple concurrent calls to client.getData(),
but we don't need it for correctness anymore.  WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message